-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
Uplift RegionVid, TermKind to rustc_type_ir, and EagerResolver to rustc_next_trait_solver
#125284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
r? lcnr |
|
r? @davidtwco rustbot has assigned @davidtwco. Use |
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
RegionVid, TermKind to rustc_type_ir, and EagerResolver to rustc_next_trait_solver
This comment has been minimized.
This comment has been minimized.
073ee90 to
53c6c46
Compare
This comment has been minimized.
This comment has been minimized.
53c6c46 to
2e47075
Compare
| use self::RegionKind::*; | ||
|
|
||
| rustc_index::newtype_index! { | ||
| /// A **ty**pe **v**ariable **ID**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this comment is wrong :3
|
r=me after nits |
2e47075 to
9fa07a4
Compare
|
@bors r=lcnr |
|
@bors rollup=never |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (9cb6bb8): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (primary -2.8%, secondary -3.4%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 671.714s -> 670.228s (-0.22%) |
RegionVid. This was complicated due to the fact that we implementpolonius_engine::AtomforRegionVid-- but I just separated that intoPoloniusRegionVid, and addedFrom/Intoimpls so it can be defined inrustc_borrowckseparately. Coherence 😵InferCtxtLiketo exposeopportunistically_resolve_{ty,ct,lt,int,float}_varso that we can upliftEagerResolverfor use in the canonicalization methods.TermKindmuch likeGenericArgKindAll of this is miscellaneous dependencies for making more
EvalCtxtmethods generic.