Conversation
rustbot
added
A-translation
Collaborator
|
|
Noratrieb
requested changes
Nov 9, 2023
Member
Noratrieb
left a comment
Noratrieb
left a comment
There was a problem hiding this comment.
one comment, r=me after that
rustbot
added
S-waiting-on-author
petrochenkov
reviewed
Nov 9, 2023
| } | ||
|
|
||
| impl Parse for Input { | ||
| // Input syntax is `env!("CFG_RELEASE")` to facilitate grepping. |
Contributor
There was a problem hiding this comment.
All this was added just a couple of weeks ago in #117256 :D
It currently has the syntax
`current_rustc_version!(env!("CFG_RELEASE"))` where the
`env!("CFG_RELEASE")` part looks like a normal expression but it is
actually parsed and processed by the `current_rustc_version` macro.
The documented rationale for this is that you'll find it if you grep for
`env!("CFG_RELEASE")`. But I think that's of very little use -- I would
personally grep for just "CFG_RELEASE" -- and it complicates the macro,
requiring the use of `syn`.
This commit simplifies the macro.
- Reduce some function exposure. - Fix some comment formatting.
And avoid duplication.
nnethercote
force-pushed
the
rustc_macros
branch
from
c824013 to
dd6bab9
Compare
rustbot
added
S-waiting-on-review
Contributor
Author
|
@Nilstrieb: I addressed the error message comment. |
Member
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (fa14810): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 673.782s -> 674.599s (0.12%) |
dtolnay
added
the
C-cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some improvements I found while reading over this code.
r? @Nilstrieb