Skip to content

Always encode RPITITs #109400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spastorino wants to merge 4 commits into from
Closed

Always encode RPITITs #109400

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
387668c
Fix impl_trait_ty_to_ty substs
spastorino Mar 17, 2023
04211b6
Fix generics_of for impl's RPITIT synthesized associated type
spastorino Mar 17, 2023
0597d42
Always encode RPITITs
spastorino Mar 20, 2023
288595b
async await nested rpit test now works
spastorino Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions tests/ui/async-await/in-trait/nested-rpit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
// edition: 2021
// known-bug: #105197
// failure-status:101
// dont-check-compiler-stderr
// [current] known-bug: #105197
// [current] failure-status:101
// [current] dont-check-compiler-stderr
// [next] compile-flags: -Zlower-impl-trait-in-trait-to-assoc-ty
Copy link
Contributor

@compiler-errors compiler-errors Mar 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am skeptical that this PR passes... I'll look into it though.

Copy link
Contributor

@compiler-errors compiler-errors Mar 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, skeptical why this PR passes.

Copy link
Contributor

@compiler-errors compiler-errors Mar 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh... this fails because we have no predicates_of for RPITITs. That doesn't seem right 🤔

Let's leave this as not updated currently?

// [next] check-pass
// revisions: current next

#![feature(async_fn_in_trait)]
#![feature(return_position_impl_trait_in_trait)]
Expand Down