Skip to content

Better method mismatch error messages #10509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
emberian wants to merge 2 commits into from
Closed

Better method mismatch error messages #10509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51bdec1
Show the name of the trait in the error message
jaeminMoon Oct 28, 2013
ab9e3a6
Adjust error message for method type mismatch
emberian Nov 16, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/librustc/middle/typeck/check/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -863,11 +863,13 @@ pub fn compare_impl_method(tcx: ty::ctxt,
if impl_m.fty.sig.inputs.len() != trait_m.fty.sig.inputs.len() {
tcx.sess.span_err(
impl_m_span,
format!("method `{}` has {} parameter(s) \
but the trait has {} parameter(s)",
tcx.sess.str_of(trait_m.ident),
impl_m.fty.sig.inputs.len(),
trait_m.fty.sig.inputs.len()));
format!("method `{}` has {} parameter{} \
but the declaration in trait `{}` has {}",
tcx.sess.str_of(trait_m.ident),
impl_m.fty.sig.inputs.len(),
if impl_m.fty.sig.inputs.len() == 1 { "" } else { "s" },
ty::item_path_str(tcx, trait_m.def_id),
trait_m.fty.sig.inputs.len()));
return;
}

Expand Down
2 changes: 1 addition & 1 deletion src/test/compile-fail/trait-impl-different-num-params.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ trait foo {
}
impl foo for int {
fn bar(&self) -> int {
//~^ ERROR method `bar` has 0 parameter(s) but the trait has 1
//~^ ERROR method `bar` has 0 parameters but the declaration in trait `foo::bar` has 1
*self
}
}
Expand Down