Skip to content

Fix -Zmeta-stats ICE by giving FileEncoder file read permissions #101014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 2 commits into from
Sep 20, 2022
Merged

Fix -Zmeta-stats ICE by giving FileEncoder file read permissions #101014

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06139e5
use `File::options()` instead of `File::create()`
isikkema-ornl Aug 25, 2022
a2cb8a4
add comment explaining read permissions
isikkema-ornl Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/rustc_serialize/src/opaque.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ impl FileEncoder {
// shaves an instruction off those code paths (on x86 at least).
assert!(capacity <= usize::MAX - max_leb128_len());

let file = File::create(path)?;
let file = File::options().read(true).write(true).create(true).truncate(true).open(path)?;

Ok(FileEncoder {
buf: Box::new_uninit_slice(capacity),
Expand Down