-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
compiletest: only take a --python argument and remove the --lldb-python / --docck-python args #96011
Copy link
Copy link
Closed
Labels
A-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Metadata
Metadata
Assignees
Labels
A-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Type
Fields
Give feedbackNo fields configured for issues without a type.
Compiletest currently has two different arguments telling it which python to use. Since #95441, both are always the same. We should change it to just one
--pythonargument to simplify things.Mentoring instructions: Change
rust/src/tools/compiletest/src/main.rs
Lines 64 to 65 in f38c5c8
to be a single
pythonargument, then changerust/src/bootstrap/test.rs
Lines 1403 to 1405 in f38c5c8
@AlecGoncharow are you interested in tackling this one too? :)
@rustbot label +A-rustbuild +A-testsuite +E-easy +E-mentor
Originally posted by @jyn514 in #95441 (comment)