-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
Rustc file lock not working on WSL #72157
Copy link
Copy link
Closed
Labels
C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.O-windowsOperating system: WindowsOperating system: Windows
Metadata
Metadata
Assignees
Labels
C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.O-windowsOperating system: WindowsOperating system: Windows
Type
Fields
Give feedbackNo fields configured for issues without a type.
WSL1 does not support
fcntl-based advisory locks, therefore the current src/librustc_data_structures/flock.rs implementation does not work.This issue can be observed by running
cargo docon a repository with many crates. Thesearch-index.jscan miss crates.According to my test
libc::flockis working on WSL. We could replacefcntlbased lock withflockbased lock for Linux. However this will break lock over NFS for Linux 2.6.11 or earlier, I can author a PR if that's okay.Related WSL issue: microsoft/WSL#1927