-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
MIR dumps should use "crate_name." as a prefix instead of "rustc.". #70767
Copy link
Copy link
Closed
Labels
A-mir-optArea: MIR optimizationsArea: MIR optimizationsA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
A-mir-optArea: MIR optimizationsArea: MIR optimizationsA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
rustc.main.SimplifyCfg-initial.after.mir(insrc/test/mir-opt/basic_assignment) is the kind of file name we have right now, but if we used the crate name instead at the start, we'd have:basic_assignment.main.SimplifyCfg-initial.after.mir.Besides being more useful when dumping a bunch of stuff outside of tests, it would let us remove the directory nesting, so that file could just be in
src/test/mir-opt, right next tobasic_assignment.rs.cc @rust-lang/wg-mir-opt