-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
ninja is only used in Windows builds on CI. #70469
Copy link
Copy link
Open
Labels
A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.Relevant to the infrastructure team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.Relevant to the infrastructure team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
AFAICT this is the only thing that adds
--enable-ninja, and it's Windows-only:rust/src/ci/scripts/install-ninja.sh
Lines 9 to 16 in b9ac291
We also autodetect
ninjaand use it, but only for MSVC specifically (#43767 / #44084).On top of being (supposedly) faster than relying on
make, IMEninjaalso has less log spew when building LLVM (but it's unclear if it would help on CI, see #70468).cc @rust-lang/infra