-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
hash_map::IterMut changed Send bounds with hashbrown #61357
Copy link
Copy link
Closed
Labels
A-collectionsArea: `std::collections`Area: `std::collections`C-bugCategory: This is a bug.Category: This is a bug.T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.Relevant to the library API team, which will review and decide on the PR/issue.regression-from-stable-to-betaPerformance or correctness regression from stable to beta.Performance or correctness regression from stable to beta.
Description
Metadata
Metadata
Assignees
Labels
A-collectionsArea: `std::collections`Area: `std::collections`C-bugCategory: This is a bug.Category: This is a bug.T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.Relevant to the library API team, which will review and decide on the PR/issue.regression-from-stable-to-betaPerformance or correctness regression from stable to beta.Performance or correctness regression from stable to beta.
Type
Fields
Give feedbackNo fields configured for issues without a type.
In 1.35,
IterMut'sSendrequiresK: Send, but in 1.36-beta it requiresK: Sync. Both are auto-derived, so it must be a change in their internals. Obviously,hashbrownis quite different than the old implementation.https://doc.rust-lang.org/1.35.0/std/collections/hash_map/struct.IterMut.html#impl-Send
https://doc.rust-lang.org/beta/std/collections/hash_map/struct.IterMut.html#impl-Send
Ditto for
ValuesMut. I'm not sure if there's any real impact in this, but it should be considered, and perhaps audit for other similar changes.cc @Amanieu, as discussed on IRC.