-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
Do something about std::deque #2343
Copy link
Copy link
Closed
Labels
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.
Milestone
Metadata
Metadata
Assignees
Labels
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.
Type
Fields
Give feedbackNo fields configured for issues without a type.
It's not used anywhere (it was imported in
resolve, but the import wasn't needed) and a comment at the top says "untested... Likely buggy." Though there actually are some tests within the module, I'm not sure if it should be in std if it's been sitting unused for a long time?In any case, if it does get kept, there's a FIXME before
deque::create: "eventually, a proper datatype plus an exported impl would be preferrable" -- that should be addressed.