-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
Tidy check for io::ErrorKind::Other in std code #102122
Copy link
Copy link
Open
Labels
A-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcT-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.Relevant to the infrastructure team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
A-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcT-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.Relevant to the infrastructure team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
We have a note in the ErrorKind documentation:
but in practice, there are cases were we do make use of it, whether in tests or by accident. We should add a check in tidy that the ErrorKind::Other string doesn't show up in std code, with an ability to opt-out similar to style checks (probably on the same line only would be best).
The ideal of course is a compiler check but I don't think there's much we can do there without a custom lint, which seems like way too much effort. The tidy check can miss things (e.g., glob imports), but that's OK.