-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
InferCtxt::tainted_by_errors_flag should be Option<ErrorGuaranteed> #100321
Copy link
Copy link
Closed
Labels
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Metadata
Metadata
Assignees
Labels
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Type
Fields
Give feedbackNo fields configured for issues without a type.
rust/compiler/rustc_infer/src/infer/mod.rs
Line 319 in 5af97e8
should be
Cell<Option<ErrorGuaranteed>>to guarantee that we emit an error when that flag is set. This is already done fortainted_by_errorsof other types in rustc.rust/compiler/rustc_middle/src/ty/context.rs
Line 537 in 5af97e8