Split is_diagnostic_assoc_item
#7074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
|
Thank you! Are you going to push a PR removing @bors r+ |
Contributor
|
📌 Commit 76bd5d2 has been approved by |
Contributor
Contributor
Author
Yes I can do that. |
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 26, 2021
Remove slice diagnostic item ...because it is unusally placed on an impl and is redundant with a lang item. Depends on rust-lang/rust-clippy#7074 (next clippy sync). ~I expect clippy tests to fail in the meantime.~ Nope tests passed... CC `@flip1995`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: none
is_diagnostic_assoc_itemintois_diag_item_methodandis_diag_trait_itemis_diag_item_methodis a bit more nuanced with thetcx.type_of(impl_id).ty_adt_def()step, so it seems better to keep that separate.sym::slicediagnostic item with theslice_alloclang item. The diagnostic item should be removed from rustc because it is on theslice_allocimpl, not slice itself (and it's not needed).