Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Jul 1, 2020

Fix the versions of packages in the multiple_crate_versions ui test by
checking in the Cargo.lock for the test package. ansi_term 0.11
depends on winapi ^0.3.4. This means means that the expected stderr for
this test would have to be updated whenever winapi 0.3 is updated
otherwise.

changelog: none

Fix the versions of packages in the multiple_crate_versions ui test by
checking in the Cargo.lock for the test package. `ansi_term 0.11`
depends on `winapi ^0.3.4`. This means means that the expected stderr for
this test would have to be updated whenever `winapi 0.3` is updated
otherwise.
@rust-highfive
Copy link

r? @matthiaskrgr

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 1, 2020
@matthiaskrgr
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Jul 1, 2020

📌 Commit 5b9c2ff has been approved by matthiaskrgr

@bors
Copy link
Contributor

bors commented Jul 1, 2020

⌛ Testing commit 5b9c2ff with merge 0860375...

@bors
Copy link
Contributor

bors commented Jul 1, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: matthiaskrgr
Pushing 0860375 to master...

@bors bors merged commit 0860375 into rust-lang:master Jul 1, 2020
@ghost ghost deleted the multiple_crate_versions_20200701 branch July 2, 2020 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants