Skip to content

Conversation

@profetia
Copy link
Member

@profetia profetia commented Jan 23, 2026

Continuation #16337

Even more fixes for handling macros

changelog: [manual_rotate] fix wrongly unmangled macros
changelog: [map_with_unused_argument_over_ranges] fix wrongly unmangled macros
changelog: [needless_bool] fix wrongly unmangled macros
changelog: [manual_is_power_of_two] fix wrongly unmangled macros
changelog: [manual_div_ceil] fix wrongly unmangled macros
changelog: [implicit_saturating_sub] fix wrongly unmangled macros
changelog: [range_minus_one] fix wrongly unmangled macros
changelog: [range_plus_one] fix wrongly unmangled macros
changelog: [manual_swap] fix wrongly unmangled macros
changelog: [let_and_return] fix wrongly unmangled macros

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 23, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 23, 2026

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Copy link
Contributor

@ada4a ada4a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a bunch of places where expr.span.ctxt() could've been reused -- highlighted just some of them

View changes since this review

@profetia profetia force-pushed the issue16293-cond2 branch 3 times, most recently from 01a1156 to 3142977 Compare January 25, 2026 22:46
@rustbot
Copy link
Collaborator

rustbot commented Jan 31, 2026

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants