Issue #16110: similar_names not triggered by example

[alt440]

Please write a short comment explaining your change (or "none" for internal only changes)
Fixes #16110
changelog: [similar_names] : Changed the lint docs to reflect its actual behavior

[rustbot]

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[github-actions]

No changes for 65c8e18

[Jarcho]

Given the fallout from this change it's probably better to change the example instead. cc @rust-lang/clippy

[alt440]

@Jarcho If we do follow this route, the documentation would have to change to specify that the similar_names lint only considers variables with same length and similar characters.

Note that the change is bigger than just the similar_names lint file because of the dogfood tests. If it wasn't for that, the change is minor: see my first commit.

[Jarcho]

It just doesn't handle insertions at the start or end of the name. Single character insertions in the middle still trigger the lint.

Note that the change is bigger than just the similar_names lint file because of the dogfood tests. If it wasn't for that, the change is minor: see my first commit.

That's exactly what I mean by the fallout. A large number of the new lint emissions are quite questionable.

[alt440]

Hey @Jarcho ,

I've reverted the fix. I added some unit tests and changed the docs.

Let me know if that's OK with you

[rustbot]

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.