Skip to content

Conversation

@ada4a
Copy link
Contributor

@ada4a ada4a commented Oct 31, 2025

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 31, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 31, 2025

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@ada4a
Copy link
Contributor Author

ada4a commented Oct 31, 2025

@rustbot blocked on #12980

@rustbot rustbot added S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Oct 31, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 31, 2025

☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts.

@llogiq
Copy link
Contributor

llogiq commented Oct 31, 2025

+6142 lines? Wow, that's not something I'll review in one go.

@ada4a
Copy link
Contributor Author

ada4a commented Oct 31, 2025

It's not as bad as it seems 😅 My part is only the last 2 commits, which should have a much smaller diff -- it's just that @Jarcho refactored formatting, and so I wanted to base my PR on top of that

@rustbot
Copy link
Collaborator

rustbot commented Dec 17, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@llogiq
Copy link
Contributor

llogiq commented Dec 18, 2025

I see. Let's wait until that PR lands then.

@rustbot blocked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants