Skip to content

Conversation

@AMS21
Copy link

@AMS21 AMS21 commented Aug 20, 2025

changelog: [unreachable]: Add configuration option to allow usage in test functions

Summary Notes

Managed by @rustbot—see help for details

@rustbot
Copy link
Collaborator

rustbot commented Aug 20, 2025

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 20, 2025
@AMS21 AMS21 force-pushed the allow_unreachable_in_tests branch from d00f467 to 329a582 Compare August 27, 2025 08:06
@rustbot
Copy link
Collaborator

rustbot commented Aug 27, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@samueltardieu
Copy link
Member

Seems that you are trying to add a new configuration option!

We are currently in a feature freeze, so we are delaying all lint-adding PRs to September 18 and #15086.

Thanks a lot for your contribution, and sorry for the inconvenience.

@rustbot note Feature-freeze
@rustbot blocked
@rustbot label +A-lint

@rustbot rustbot added S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work A-lint Area: New lints and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Aug 27, 2025
@samueltardieu samueltardieu added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work labels Sep 17, 2025
@dswij
Copy link
Member

dswij commented Oct 31, 2025

r? clippy

@rustbot rustbot assigned Alexendoo and unassigned dswij Oct 31, 2025
@Alexendoo Alexendoo removed the A-lint Area: New lints label Oct 31, 2025
@Alexendoo
Copy link
Member

What's the motivation here? In my view the combination of a restriction lint & using it enough in tests that a configuration option is better than a one off allow seems fairly niche

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants