Derive Clone along with Copy on Rust 1.21
#1085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pepyakin
force-pushed
the
builtin-clone-impls
branch
from
e337ceb to
e3e0db1
Compare
fitzgen
approved these changes
Oct 17, 2017
src/codegen/mod.rs
Outdated
| derives.push("Clone"); | ||
| } else { | ||
| needs_clone_impl = true; | ||
| if used_template_params.is_some() { |
Member
There was a problem hiding this comment.
Flatten the nested if/else?
if ctx.options().rust_features().builtin_clone_impls() || used_template_params.is_some() {
...
} else {
...
}
pepyakin
force-pushed
the
builtin-clone-impls
branch
from
e3e0db1 to
1886fe2
Compare
Contributor
Author
|
@fitzgen done! |
Member
|
@bors-servo r+ |
|
📌 Commit 1886fe2 has been approved by |
|
🔒 Merge conflict |
|
☔ The latest upstream changes (presumably #1084) made this pull request unmergeable. Please resolve the merge conflicts. |
pepyakin
force-pushed
the
builtin-clone-impls
branch
from
1886fe2 to
f0e97bb
Compare
|
☔ The latest upstream changes (presumably #1094) made this pull request unmergeable. Please resolve the merge conflicts. |
pepyakin
force-pushed
the
builtin-clone-impls
branch
from
f0e97bb to
a84e263
Compare
pepyakin
force-pushed
the
builtin-clone-impls
branch
from
a84e263 to
2e7d997
Compare
Contributor
Author
|
@bors-servo r=fitzgen |
|
📌 Commit 2e7d997 has been approved by |
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #934
r? @fitzgen or @emilio