Fix range expr expected type suggest#20933
Closed
A4-Tacks wants to merge 1 commit intorust-lang:masterfrom
Closed
Conversation
Example
---
```rust
enum State { Stop }
fn bar(x: core::ops::Range<State>) {}
fn foo() {
bar(State::Stop..$0)
}
```
**Before this PR**
```text
std::ops::Range {…}~ std::ops::Range { start: Idx, end: Idx }
```
**After this PR**
```text
State::Stop~ State::Stop
```
rustbot
added
the
S-waiting-on-review
41 tasks
Collaborator
|
☔ The latest upstream changes (possibly #21333) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
|
I'm closing this since we established than we need a more comprehensive approach for inferring the expected type than replicating inference. |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example
Before this PR
After this PR