Re-add rust-analyzer.cargo.sysrootQueryMetadata

[darichey]

#17795 removed this option, turning it on for everyone. This commit adds it back, still on by default.

At work, users are effectively offline, so the initial cargo metadata will always fail. The --no-deps retry will succeed, but the experience with this path is very poor, because a ton of std stuff fails to resolve (some still works, I can't tell the pattern). Something like this is probably happening in #17759.

We want this config option so we can turn it off by default for our users and always use the stitched sysroot library.

[darichey]

The --no-deps retry will succeed, but the experience with this path is very poor, because a ton of std stuff fails to resolve

In fact, this experience is so poor, I wonder if it's even worth supporting?

[darichey]

If we'd like to get rid of the stitched sysroot stuff, a longer term solution could be teaching rust-analyzer to use something other than cargo metadata for this. At work, the sysroot builds with Buck, so presumably we could use it to get the info we need.

[davidbarsky]

I'm a plus one on this, but I'd prefer someone else merge it. I can, need be.

[lnicola]

r? @davidbarsky

[davidbarsky]

approved! didn't want to be the only one to approve it for conflict of interest reasons.

[lnicola]

I know, but I wasn't able to merge it because of your pending "changes requested" review.

[davidbarsky]

I know, but I wasn't able to merge it because of your pending "changes requested" review.

Wild, okay! I thought it was overridable.

[lnicola]

I know, check out my struggles in the history above 😕.

[davidbarsky]

I know, check out my struggles in the history above 😕.

I didn't see those in email and I didn't stroll up. I'm sorry about that.

[Veykril]

At work, users are effectively offline, so the initial cargo metadata will always fail. The --no-deps retry will succeed, but the experience with this path is very poor, because a ton of std stuff fails to resolve (some still works, I can't tell the pattern).

Hmm, that seems very odd to me? The no-deps retry should yield the same result as the stitched workspace

[davidbarsky]

I'll let @darichey expand, but he tells me "it doesn't".

(I've noticed that weirdness as well, for what it's worth.)

[Veykril]

In fact, I can't reproduce this. If I run r-a offline I still get resolved standard library stuff. I'd really prefer to get rid of this config as I'd like to drop the stitched workspace hack in the near future

[darichey]

Maybe it's specific to json workspace project loading? I'll try to get a simple repro today

[Veykril]

Perhaps, I only tried a basic cargo setup

[Veykril]

Opened #18590 to track this, please drop any findings for this there