-
Notifications
You must be signed in to change notification settings - Fork 253
Update cargo revision #1274
Update cargo revision #1274
Conversation
|
I'll rebase after merging #1276 |
|
Generally we should update cargo in line with the rust-lang/rust submodule as that is the version of cargo that the release will be built with. This pr is a little later, but tbf I don't think it's a big deal this time so: |
|
📌 Commit bb2eb1e has been approved by |
|
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message |
|
☔ The latest upstream changes (presumably #1272) made this pull request unmergeable. Please resolve the merge conflicts. |
I'm sorry for missing policy. |
|
Well it's just that it isn't obvious (ie wasn't to me) how the release version picks cargo & clippy, so I tend to bang on about it so more people will know. |
…o 245818076052dd7178f5bb7585f5aec5b6c1e03e
|
@alexheretic I've revased and push :) |
|
@bors r+ |
|
📌 Commit 924862f has been approved by |
Update cargo revision diff: rust-lang/cargo@907c0fe...2458180
|
💔 Test failed - checks-travis |
|
@bors retry |
Update cargo revision diff: rust-lang/cargo@907c0fe...2458180
|
☀️ Test successful - checks-travis |
diff: rust-lang/cargo@907c0fe...2458180