This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Fix crashes when editing wide characters spanning 2 u16s (UTF-16)
#1112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xanewok
changed the title
u16s (UTF-16)
Xanewok
commented
Nov 2, 2018
Contributor
Author
Xanewok
left a comment
Xanewok
left a comment
There was a problem hiding this comment.
Just noticed one caveat, will need to fix that before it lands.
Contributor
Author
|
With rust-lang/rfcs#2457 merged we additionally now have to be careful around Unicode identifiers and their, currently wrong, (ノ ゜Д゜)ノ ︵ ┻━┻
UTF-16 is a can of worms. While this PR fixes an unrecoverable crash and possible text buffer corruption, the remaining UTF-16 Range thing is mostly displaying diagnostics, so I'd treat it with a lower priority (but still something that we need to fix!). |
Xanewok
force-pushed
the
fix-format-range
branch
from
84992c2 to
b672685
Compare
Contributor
Author
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on rust-dev-tools/rls-vfs#24.Fixes #1104.
r? @nrc