Skip to content

Conversation

@kalisjoshua
Copy link
Contributor

Under the heading "What the process is" a word was duplicated assumingly by
accident:

"The sub-team will will either close"

... the above should probably be:

"The sub-team will either close"

Under the heading "What the process is" a word was duplicated assumingly by
accident:

  > "The sub-team will will either close"

... the above should probably be:

  > "The sub-team will either close"
@alexcrichton alexcrichton merged commit 73a65af into rust-lang:master Feb 15, 2017
@alexcrichton
Copy link
Member

Thanks!

@kalisjoshua
Copy link
Contributor Author

Additionally I noticed a mix of the use of "pull request" and "PR". I would think that using a consistent term would be preferable. I didn't make the change because I didn't know what the project would prefer; I thought I read that GitHub has a position on this but I am having a hard time finding the article.

@kalisjoshua kalisjoshua deleted the consistent-wording branch February 15, 2017 19:37
@alexcrichton
Copy link
Member

Ah yeah consistency sounds good! Want to switch to the more descriptive "pull request"?

@alexcrichton
Copy link
Member

(or the other, either way's fine by me at least)

@kalisjoshua
Copy link
Contributor Author

I'll open a new pull request later today. Thanks.

@Centril Centril added the not-rfc For PRs that fix things like spelling mistakes, wrong file names, etc. label Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-rfc For PRs that fix things like spelling mistakes, wrong file names, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants