Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions text/0000-movecell.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
- Feature Name: move_cell
- Start Date: 2016-06-15
- RFC PR: (leave this empty)
- Rust Issue: (leave this empty)

# Summary
[summary]: #summary

Extend `Cell` to work with non-`Copy` types.

# Motivation
[motivation]: #motivation

It allows safe inner-mutability of non-`Copy` types without the overhead of `RefCell`'s reference counting.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which types? What is a concrete use case for this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


# Detailed design
[design]: #detailed-design

```rust
impl<T> Cell<T> {
fn set(&mut self, val: T);
fn replace(&mut self, val: T) -> T;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should all be &self right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops

fn into_inner(self) -> T;
}

impl<T: Copy> Cell<T> {
fn get(&self);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> T

}

impl<T: Default> Cell<T> {
fn take(&mut self) -> T;
}
```

The `get` method is kept but is only available for `T: Copy`. The `set` method is available for all `T`.

The `into_inner` and `replace` methods are added, which allow the value in a cell to be read even if `T` is not `Copy`. The `get` method can't be used since the cell must always contain a valid value.

Finally, a `take` method is added which is equivalent to `self.replace(Default::default())`.

# Drawbacks
[drawbacks]: #drawbacks

It makes the `Cell` type more complicated.

# Alternatives
[alternatives]: #alternatives

The alternative is to use the `MoveCell` type from crates.io which provides the same functionality.

# Unresolved questions
[unresolved]: #unresolved-questions

None