Skip to content

use intptrcast for heap_allocator test; then it should work on Windows#809

Merged
bors merged 7 commits into
rust-lang:masterfrom
RalfJung:intptrcast
Jun 30, 2019
Merged

use intptrcast for heap_allocator test; then it should work on Windows#809
bors merged 7 commits into
rust-lang:masterfrom
RalfJung:intptrcast

Conversation

@RalfJung
Copy link
Copy Markdown
Member

@RalfJung RalfJung commented Jun 30, 2019

No description provided.

@RalfJung
Copy link
Copy Markdown
Member Author

RalfJung commented Jun 30, 2019

@bors r+

@bors
Copy link
Copy Markdown
Contributor

bors commented Jun 30, 2019

📌 Commit b067313 has been approved by RalfJung

@RalfJung
Copy link
Copy Markdown
Member Author

RalfJung commented Jun 30, 2019

@bors r+

@bors
Copy link
Copy Markdown
Contributor

bors commented Jun 30, 2019

📌 Commit 0ea4b50 has been approved by RalfJung

@bors
Copy link
Copy Markdown
Contributor

bors commented Jun 30, 2019

⌛ Testing commit 0ea4b50 with merge b0af195...

bors added a commit that referenced this pull request Jun 30, 2019
@bors
Auto merge of #809 - RalfJung:intptrcast, r=RalfJung
b0af195 
use intptrcast for heap_allocator test; then it should work on Windows
@bors
Copy link
Copy Markdown
Contributor

bors commented Jun 30, 2019

💔 Test failed - status-appveyor

@RalfJung
Copy link
Copy Markdown
Member Author

RalfJung commented Jun 30, 2019

Well that's odd...

error[E0080]: Miri evaluation error: a raw memory access tried to access part of a pointer value as raw bytes
  --> $DIR/heap_allocator.rs:43:24
   |
43 |             assert_eq!((ptr.as_ptr() as usize) % align, 0,
   |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Miri evaluation error: a raw memory access tried to access part of a pointer value as raw bytes

So calling the allocation function actually succeeds, but then later checking alignment does not.

@RalfJung
Copy link
Copy Markdown
Member Author

RalfJung commented Jun 30, 2019

@bors try

@bors
Copy link
Copy Markdown
Contributor

bors commented Jun 30, 2019

⌛ Trying commit 1f945cc with merge 58df88f...

bors added a commit that referenced this pull request Jun 30, 2019
@bors
Auto merge of #809 - RalfJung:intptrcast, r=<try>
58df88f 
use intptrcast for heap_allocator test; then it should work on Windows
@RalfJung
Copy link
Copy Markdown
Member Author

RalfJung commented Jun 30, 2019

Wow, MIRI_BACKTRACE makes everything just crazy slow, at least on Windows.

@oli-obk this build log looks like we are throwing and catching tons of Miri errors. That doesn't seem right.

@RalfJung
Copy link
Copy Markdown
Member Author

RalfJung commented Jun 30, 2019

@bors try

@bors
Copy link
Copy Markdown
Contributor

bors commented Jun 30, 2019

⌛ Trying commit 2a92157 with merge 899e5bf...

bors added a commit that referenced this pull request Jun 30, 2019
@bors
Auto merge of #809 - RalfJung:intptrcast, r=<try>
899e5bf 
use intptrcast for heap_allocator test; then it should work on Windows
@RalfJung
Copy link
Copy Markdown
Member Author

RalfJung commented Jun 30, 2019

D'oh, I've failed to actually set the compiler flag correctly...

@bors r+

@bors
Copy link
Copy Markdown
Contributor

bors commented Jun 30, 2019

📌 Commit 78261b7 has been approved by RalfJung

@bors
Copy link
Copy Markdown
Contributor

bors commented Jun 30, 2019

⌛ Testing commit 78261b7 with merge bb45bdb...

bors added a commit that referenced this pull request Jun 30, 2019
@bors
Auto merge of #809 - RalfJung:intptrcast, r=RalfJung
bb45bdb 
use intptrcast for heap_allocator test; then it should work on Windows
@bors
Copy link
Copy Markdown
Contributor

bors commented Jun 30, 2019

💔 Test failed - status-appveyor

@RalfJung
Copy link
Copy Markdown
Member Author

RalfJung commented Jun 30, 2019

@bors try

@bors
Copy link
Copy Markdown
Contributor

bors commented Jun 30, 2019

⌛ Trying commit 20753d9 with merge 2d5620e...

bors added a commit that referenced this pull request Jun 30, 2019
@bors
Auto merge of #809 - RalfJung:intptrcast, r=<try>
2d5620e 
use intptrcast for heap_allocator test; then it should work on Windows
@bors
Copy link
Copy Markdown
Contributor

bors commented Jun 30, 2019

💔 Test failed - checks-travis

@RalfJung
Copy link
Copy Markdown
Member Author

RalfJung commented Jun 30, 2019

@bors try

@bors
Copy link
Copy Markdown
Contributor

bors commented Jun 30, 2019

⌛ Trying commit 7d2bfd4 with merge a09bafe...

bors added a commit that referenced this pull request Jun 30, 2019
@bors
Auto merge of #809 - RalfJung:intptrcast, r=<try>
a09bafe 
use intptrcast for heap_allocator test; then it should work on Windows
@bors
Copy link
Copy Markdown
Contributor

bors commented Jun 30, 2019

💔 Test failed - checks-travis

@RalfJung
Copy link
Copy Markdown
Member Author

RalfJung commented Jun 30, 2019

Found it! There was a bug in the alignment we used for the system allocator (malloc and friends).

I expanded the heap_allocator test to cover this on all platforms now.

@bors r+

@bors
Copy link
Copy Markdown
Contributor

bors commented Jun 30, 2019

📌 Commit 53c72ba has been approved by RalfJung

@bors
Copy link
Copy Markdown
Contributor

bors commented Jun 30, 2019

⌛ Testing commit 53c72ba with merge 9dd1ff5...

bors added a commit that referenced this pull request Jun 30, 2019
@bors
Auto merge of #809 - RalfJung:intptrcast, r=RalfJung
9dd1ff5 
use intptrcast for heap_allocator test; then it should work on Windows
@RalfJung
Copy link
Copy Markdown
Member Author

RalfJung commented Jun 30, 2019

@bors r- retry

@RalfJung
Copy link
Copy Markdown
Member Author

RalfJung commented Jun 30, 2019

Aaaand found a bug in libstd. ;) rust-lang/rust#62251

@bors r+

@bors
Copy link
Copy Markdown
Contributor

bors commented Jun 30, 2019

📌 Commit cb6d4f0 has been approved by RalfJung

@bors
Copy link
Copy Markdown
Contributor

bors commented Jun 30, 2019

⌛ Testing commit cb6d4f0 with merge cc5878b...

bors added a commit that referenced this pull request Jun 30, 2019
@bors
Auto merge of #809 - RalfJung:intptrcast, r=RalfJung
cc5878b 
use intptrcast for heap_allocator test; then it should work on Windows
@bors
Copy link
Copy Markdown
Contributor

bors commented Jun 30, 2019

💥 Test timed out

@RalfJung
Copy link
Copy Markdown
Member Author

RalfJung commented Jun 30, 2019

@bors retry

bors added a commit that referenced this pull request Jun 30, 2019
@bors
Auto merge of #809 - RalfJung:intptrcast, r=RalfJung
2a4c4ad 
use intptrcast for heap_allocator test; then it should work on Windows
@bors
Copy link
Copy Markdown
Contributor

bors commented Jun 30, 2019

⌛ Testing commit cb6d4f0 with merge 2a4c4ad...

@bors
Copy link
Copy Markdown
Contributor

bors commented Jun 30, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: RalfJung
Pushing 2a4c4ad to master...

@bors bors merged commit cb6d4f0 into rust-lang:master Jun 30, 2019
@bors bors mentioned this pull request Jun 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RalfJung @bors