Skip to content

Fix QNX build error#4879

Merged
tgross35 merged 1 commit intorust-lang:mainfrom
Hoverbear:hoverbear/fix-nto
Dec 17, 2025
Merged

Fix QNX build error#4879
tgross35 merged 1 commit intorust-lang:mainfrom
Hoverbear:hoverbear/fix-nto

Conversation

@Hoverbear
Copy link
Contributor

Description

As noted in https://github.com/rust-lang/libc/pull/4609/files#r2607712816, on *-nto-qnx710 the codebase seems to currently fail to compile:

error: type `types::Padding<i32>` is more private than the item `neutrino::ClockPeriod`
    --> src/unix/nto/neutrino.rs:1244:5
     |
1244 | /     pub fn ClockPeriod(
1245 | |         __id: crate::clockid_t,
1246 | |         _new: *const crate::_clockperiod,
1247 | |         __old: *mut crate::_clockperiod,
1248 | |         __reserved: Padding<c_int>,
1249 | |     ) -> c_int;
     | |_______________^ function `neutrino::ClockPeriod` is reachable at visibility `pub`
     |
note: but type `types::Padding<i32>` is only usable at visibility `pub(crate)`
    --> src/types.rs:17:1
     |
  17 | pub(crate) struct Padding<T: Copy>(MaybeUninit<T>);
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     = note: `-D private-interfaces` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(private_interfaces)]`

I believe the change from that PR may have been inadvertent given the other contents.

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI
    • This failed with
      cargo:rustc-link-search=native=/home/ana/git/rust-lang/libc/target/x86_64-pc-nto-qnx710/debug/build/libc-test-ae02735b35db6470/out
    
    --- stderr
    
    thread 'main' panicked at ctest/src/ffi_items.rs:141:25:
    not implemented: Foreign functions are unlikely to have any other pattern.
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
    

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, huh, yeah this certainly wasn't intentional. Thank you!

@tgross35 tgross35 added this pull request to the merge queue Dec 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 17, 2025
@tgross35 tgross35 added this pull request to the merge queue Dec 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 17, 2025
@tgross35 tgross35 added this pull request to the merge queue Dec 17, 2025
Merged via the queue into rust-lang:main with commit b7ee745 Dec 17, 2025
50 of 51 checks passed
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Jan 3, 2026
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Jan 3, 2026
(backport <rust-lang#4879>)
(cherry picked from commit b7ee745)
@tgross35 tgross35 mentioned this pull request Jan 3, 2026
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Jan 3, 2026
(backport <rust-lang#4879>)
(cherry picked from commit b7ee745)
github-merge-queue bot pushed a commit that referenced this pull request Jan 3, 2026
(backport <#4879>)
(cherry picked from commit b7ee745)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Jan 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-unix stable-applied This PR has been cherry-picked to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants