Use unique errno values for AIX#4507
Merged
tgross35 merged 1 commit intorust-lang:mainfrom Jun 29, 2025
Merged
Conversation
Contributor
|
Can confirm this is the case on an AIX 7.3 machine I have access to. Therefore, this change looks good to me. |
tgross35
approved these changes
Jun 28, 2025
Contributor
tgross35
left a comment
There was a problem hiding this comment.
Thanks @xingxue-ibm for the PR and @collinfunk for reviewing!
I'm assuming you want this in 0.2 so
@rustbot label +stable-nominated
5fcc92e to
fa6a299
Compare
Contributor
Author
|
Thanks so much, @collinfunk and @tgross35! Yes, it will be great if the fix can be included in the stable branch. |
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Jul 29, 2025
(backport <rust-lang#4507>) (cherry picked from commit fa6a299)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AIX defines some
errnovalues as aliases of othererrnovalues under the_ALL_SOURCEmacro, but the POSIX standard requires eacherrnoto be unique. This also causes some crates, such asnix, to fail. This PR updates the affectederrnovalues inlibcto address the issue.Sources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI