-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Separate L4Re from Linux code, add aarch64 and enable tests #4479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Some changes occurred in the Android module cc @maurer |
92284e5 to
40a082a
Compare
|
Hi @tgross35, this is the refactoring of the recent L4Re PR: #4383 (which is kept around just in case). I think the failure of the freebsd nightly checks is not my fault. The rest succeeds now. I did most of what you requested in your comment on the old PR, I just kept the linux/mod.rs file around since there is a massive part of code that is linux-only and is not supported by L4Re and it did not seem to make sense to put it all in shared.rs. Also, I put some more code that's shared from the sub modules (emscripten, android, linux, l4re) up in linux_like/mod.rs. In theory, I think there's potential to do that with more code, that's just the one that I would have put in shared.rs but realized that it could go into linux_like/mod.rs instead. |
26e9993 to
5b60e70
Compare
tgross35
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this has taken a while to get to, but thank you for all the changes here! The shape of this one looks much better. I have a handful of small comments but will need to take a deeper look at the big refactor portions again.
|
@rustbot author, for the above review and a rebase |
|
Reminder, once the PR becomes ready for a review, use |
|
Nice, thanks a lot for baring with me for this large change(s)! |
(backport <rust-lang#4479>) (cherry picked from commit 789b935)
The L4Re code was previously attached to the Linux code which was not correct in many ways. This commit separates the L4Re code and enables the libc-tests and includes the fixes for the failing tests. (backport <rust-lang#4479>) (cherry picked from commit 2fe1d91)
(backport <rust-lang#4479>) (cherry picked from commit 980c923)
(backport <rust-lang#4479>) (cherry picked from commit c827adf)
(backport <rust-lang#4479>) (cherry picked from commit 1034d70)
(backport <rust-lang#4479>) (cherry picked from commit 789b935)
The L4Re code was previously attached to the Linux code which was not correct in many ways. This commit separates the L4Re code and enables the libc-tests and includes the fixes for the failing tests. (backport <rust-lang#4479>) (cherry picked from commit 2fe1d91)
(backport <rust-lang#4479>) (cherry picked from commit 980c923)
(backport <rust-lang#4479>) (cherry picked from commit c827adf)
(backport <rust-lang#4479>) (cherry picked from commit 1034d70)
The L4Re code was previously attached to the Linux code which was not correct in many ways. This commit separates the L4Re code and enables the libc-tests and includes the fixes for the failing tests. (backport <rust-lang#4479>) (cherry picked from commit 2fe1d91)
(backport <rust-lang#4479>) (cherry picked from commit 980c923)
(backport <rust-lang#4479>) (cherry picked from commit c827adf)
(backport <rust-lang#4479>) (cherry picked from commit 1034d70)
The L4Re code was previously attached to the Linux code which was not correct in many ways. This commit separates the L4Re code and enables the libc-tests and includes the fixes for the failing tests. Aarch64 is added as a second supported architecture (more to come).
Sources
L4Re-adapted version of uclibc: https://github.com/kernkonzept/l4re-core/tree/master/uclibc/lib.
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI