Add strftime* for illumos. #4453
Conversation
tgross35
changed the title
|
Any chance to get this added also for Solaris? This should be common for both Illumos and Solaris. |
devnexen
force-pushed
the
gh4449
branch
2 times, most recently
from
eed2acb to
40673d5
Compare
tgross35
left a comment
tgross35
left a comment
There was a problem hiding this comment.
Looks like there is a Solaris test failure, does this need a different link name or something?
bad strftime function pointer: rust: 140736400656704 (0x7fffbf2b0940) != c 140736400656800 (0x7fffbf2b09a0)
|
Seems like it, I ll have a look later today. |
src/unix/solarish/mod.rs
Outdated
|
|
||
| pub fn secure_getenv(name: *const c_char) -> *mut c_char; | ||
|
|
||
| #[link_name = "__xpg4_strftime"] |
There was a problem hiding this comment.
Doing this unconditionally for both Solaris and illumos is going to break the latter, I believe.
There was a problem hiding this comment.
in fact I m just trying to see if it fixes solaris case :) thus this PR being a draft for now
There was a problem hiding this comment.
@pfmooney would you be able to check the current version?
devnexen
force-pushed
the
gh4449
branch
2 times, most recently
from
283f069 to
237d749
Compare
tgross35
left a comment
tgross35
left a comment
There was a problem hiding this comment.
Assuming this is good on Illumos since link_name isn't overridden. Thank you!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
tgross35
added
the
stable-nominated
[ref](https://smartos.org/man/3C/strftime) [ref](https://docs.oracle.com/cd/E88353_01/html/E37843/strftime-3c.html) Fixes: rust-lang#4449 (backport <rust-lang#4453>) (cherry picked from commit f4964b5)
[ref](https://smartos.org/man/3C/strftime) [ref](https://docs.oracle.com/cd/E88353_01/html/E37843/strftime-3c.html) Fixes: #4449 (backport <#4453>) (cherry picked from commit f4964b5)
tgross35
added
stable-applied
5 participants
ref
Fixes: #4449