Add the TCP_FUNCTION_BLK and TCP_FUNCTION_ALIAS socket options#4047
Merged
tgross35 merged 1 commit intorust-lang:mainfrom Nov 16, 2024
Merged
Add the TCP_FUNCTION_BLK and TCP_FUNCTION_ALIAS socket options#4047tgross35 merged 1 commit intorust-lang:mainfrom
tgross35 merged 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
3 tasks
For FreeBSD only
eb40881 to
2e8be88
Compare
Contributor
Author
|
The error looks unrelated to my change. For one thing, it was a Linux build that failed. For another, this is the error: |
tgross35
approved these changes
Nov 16, 2024
Contributor
There was a problem hiding this comment.
The error looks unrelated to my change. For one thing, it was a Linux build that failed. For another, this is the error:
rustc-LLVM ERROR: Cannot select: 0x7fe87eb15000: f32,ch = load<(load (s16) from %ir.0), anyext from f16> 0x7fe87eb15a10, 0x7fe87eaf6540, undef:i64, src/fmt/float.rs:238:30 0x7fe87eaf6540: i64,ch = CopyFromReg 0x7fe87eabb468, Register:i64 %0 0x7fe87eb15af0: i64 = Register %0 0x7fe87eb155b0: i64 = undef In function: _ZN4core3fmt5float50_$LT$impl$u20$core..fmt..Debug$u20$for$u20$f16$GT$3fmt17h9203c7e9bc0be64fE error: could not compile `core` (lib)
That was just a bug on the most recent nightly, I think it should be fixed with the one that just released.
@rustbot label +stable-nominated
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 16, 2024
For FreeBSD only (backport <rust-lang#4047>) (cherry picked from commit 2e8be88)
Merged
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 16, 2024
For FreeBSD only (backport <rust-lang#4047>) (cherry picked from commit 2e8be88)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 16, 2024
For FreeBSD only (backport <rust-lang#4047>) (cherry picked from commit 2e8be88)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 16, 2024
For FreeBSD only (backport <rust-lang#4047>) (cherry picked from commit 2e8be88)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For FreeBSD only
Description
These two socket options are used to get and set a socket's TCP stack, on FreeBSD only.
Sources
https://man.freebsd.org/cgi/man.cgi?query=tcp
https://github.com/freebsd/freebsd-src/blob/976e1d36be688166e140cbaded01d433c61e6d47/sys/netinet/tcp.h#L229
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI