OpenBSD: add sendmmsg and recvmmsg support.#3831
Conversation
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
|
Some changes occurred in OpenBSD module cc @semarie |
semarie
left a comment
There was a problem hiding this comment.
it doesn't pass the test suite under OpenBSD.
cargo:warning=/data/semarie/repos/rust/build-libc/build/x86_64-unknown-openbsd/debug/build/libc-test-29cac031f36c8215/out/main.c:15544:51: error: must use 'struct' tag to refer to type 'mmsghdr'
cargo:warning= int (*__test_fn_sendmmsg(void))(int, mmsghdr*, unsigned int, int) {
cargo:warning= ^
cargo:warning= struct
cargo:warning=/data/semarie/repos/rust/build-libc/build/x86_64-unknown-openbsd/debug/build/libc-test-29cac031f36c8215/out/main.c:15549:51: error: must use 'struct' tag to refer to type 'mmsghdr'
cargo:warning= int (*__test_fn_recvmmsg(void))(int, mmsghdr*, unsigned int, int, struct timespec*) {
cargo:warning= ^
cargo:warning= struct
cargo:warning=2 errors generated.
--- stderr
rust version: 1.80.0
error occurred: Command "/usr/local/bin/sccache" "cc" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-gdwarf-2" "-fno-omit-frame-pointer" "-m64" "--target=x86_64-unknown-openbsd" "-Wall" "-Wextra" "-Wall" "-Wextra" "-Werror" "-Wno-unused-parameter" "-Wno-type-limits" "-Wno-address-of-packed-member" "-Wno-unknown-warning-option" "-Wno-deprecated-declarations" "-Wno-deprecated-declarations" "-o" "/data/semarie/repos/rust/build-libc/build/x86_64-unknown-openbsd/debug/build/libc-test-29cac031f36c8215/out/08e68c28a9818392-main.o" "-c" "/data/semarie/repos/rust/build-libc/build/x86_64-unknown-openbsd/debug/build/libc-test-29cac031f36c8215/out/main.c" with args cc did not execute successfully (status code exit status: 1).
semarie
left a comment
There was a problem hiding this comment.
LGTM now (but getnameinfo break the build)
|
This is follow up of #3703 |
| reallocarray | ||
| reboot | ||
| recvmsg | ||
| recvmmsg |
There was a problem hiding this comment.
Could you add sendmmsg and mmsghdr?
|
OpenBSD and NetBSD actually seem to have a slightly different signature for This doesn't seem worth special casing on, leaving it |
(backport <rust-lang#3831>) (cherry picked from commit c369185)
close #3696