Merged
Conversation
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
devnexen
added a commit
to devnexen/libc
that referenced
this pull request
May 27, 2024
Closed
tgross35
added
the
stable-nominated
tgross35
reviewed
Aug 13, 2024
| hint: *const ::c_void, | ||
| unparkhint: *mut ::c_void, | ||
| ) -> ::c_int; | ||
| pub fn _lwp_unpark(id: ::lwpid_t, hint: *const ::c_void) -> ::c_int; |
Contributor
There was a problem hiding this comment.
Optional nit: id is called lwp per https://man.netbsd.org/_lwp_unpark.2
tgross35
reviewed
Aug 13, 2024
|
|
||
| pub fn reboot(mode: ::c_int, bootstr: *mut ::c_char) -> ::c_int; | ||
|
|
||
| #[link_name = "___lwp_park60"] |
Contributor
There was a problem hiding this comment.
Do you have a link/source referencing the link name? I can't seem to find it mentioned anywhere
Contributor
Author
There was a problem hiding this comment.
note that rust uses directly the "real" symbol.
Contributor
|
One question and one optional nit, otherwise lgtm. Relevant sources:
@rustbot author |
devnexen
force-pushed
the
netbsd_lwp_unpark
branch
from
9abcb74 to
4769aaa
Compare
Contributor
Author
|
@rustbot ready |
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Aug 16, 2024
(backport <rust-lang#3721>) (cherry picked from commit 4769aaa)
tgross35
added
stable-applied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.