Add missing constants for Android #3536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
r? @JohnTitor (rustbot has picked a reviewer for you, use r? to override) |
JohnTitor
approved these changes
Jan 13, 2024
Member
|
Sorry but could you rebase onto main? We're in the middle of the merge queue migration and the CI config of the base branch here doesn't trigger full CI (enqueueing also doesn't currently). |
GuillaumeGomez
force-pushed
the
constants-android
branch
from
8233074 to
1143a8d
Compare
Member
Author
|
No problem, done! |
Member
|
Thanks! Now CI on PRs will be triggered by every push, could you make it green? |
Member
Author
|
Oh that's convenient! Will make it much easier for you. Thanks for telling me. :) |
GuillaumeGomez
force-pushed
the
constants-android
branch
from
1143a8d to
589285e
Compare
Member
Author
|
Just like for linux, it's weird it doesn't find them as they're all present in include/linux/sched.h. Oh well. |
GuillaumeGomez
force-pushed
the
constants-android
branch
from
589285e to
9bddac4
Compare
Member
|
Maybe it's related that our Android SDK/NDK is too old 🤔(I tried to update but it's quite complex and it hasn't been still a thing: #3439) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These constants are also available in Android (but not emscripten).
This is a follow-up of #3515.
CI might fail a few times before I figure out if I need to ignore these new constants in the tests or not...