With: Ensure inner sink is ready before sending item #1880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Nice, thanks for the PR! Can you add a test to ensure that this behavior doesn't regress? |
Previously the `With` implementation never consulted the inner sink `poll_ready` before initiating a send operation. After changes the `With` combinator is considered ready when processing of previous item has been completed and the inner sink is ready. Additionally remove buffered state since it isn't actually used. Issue: #1834
Contributor
Author
|
Added a regression test & rebased. |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
Withimplementation never consulted the inner sinkpoll_readybefore initiating a send operation.After changes the
Withcombinator is considered ready when processingof previous item has been completed and the inner sink is ready.
Additionally remove buffered state since it isn't actually used.
Issue: #1834