Skip to content

Conversation

@Kroisse
Copy link
Contributor

@Kroisse Kroisse commented Sep 20, 2018

There is no advanced changes with new API like using Pin<Rc<T>> or else. Just a direct conversion from before.

Note: it depends on rust-lang/pin-utils#9.

@Thomasdezeeuw
Copy link
Contributor

This would close #1265.

@Thomasdezeeuw
Copy link
Contributor

I think rust-lang/rust#54339 breaks even more stuff.

@Kroisse
Copy link
Contributor Author

Kroisse commented Sep 21, 2018

I've assumed that there is a bug in Box::pinned, or impl<'a, T, F> UnsafeFutureObj<'a, T> for Pin<Box<F>> in stdlib.

@Thomasdezeeuw Thank you. It'll be helpful to investigate it.

@Kroisse
Copy link
Contributor Author

Kroisse commented Sep 21, 2018

@cramertj
Copy link
Member

cramertj commented Oct 1, 2018

Thanks for the PR! This was merged as part of #1268.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants