Fix unsoundness on invalid utf-8 inputs #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, unchecked user input bytes were passed into `str::from_utf8_unchecked`, which is unsound as it was within a safe function. It's been revised to check the user input and fail if there's invalid input.
Contributor
|
Thanks! Must of missed it when reviewing other's prs |
This was referenced Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, unchecked user input bytes were passed into
str::from_utf8_unchecked, which was unsound as it was within a safefunction. It's been revised to check the user input and fail if there's
invalid input.
For a file with fun contents of broken UTF-8 to test with, see https://www.cl.cam.ac.uk/~mgk25/ucs/examples/UTF-8-test.txt