try using #[cfg(bootstrap)] for #[unsafe(naked)]#821
Merged
tgross35 merged 1 commit intoApr 17, 2025
Conversation
folkertdev
force-pushed
the
naked-unsafe-attribute-bootstrap
branch
from
acb349a to
8e2a72a
Compare
Contributor
|
The failures are probably from the |
folkertdev
force-pushed
the
naked-unsafe-attribute-bootstrap
branch
from
8e2a72a to
86ae34e
Compare
Contributor
Author
|
I think I got it, I just failed to actually read the code before. |
tgross35
approved these changes
Apr 17, 2025
Contributor
tgross35
left a comment
tgross35
left a comment
There was a problem hiding this comment.
I haven't had a chance to test this all the way through, but might as well try it
tgross35
force-pushed
the
naked-unsafe-attribute-bootstrap
branch
from
86ae34e to
cd167cf
Compare
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Apr 17, 2025
Includes the following changes: * Replace `#[naked]` with `#[unsafe(naked)]` [1] [2] * Replace `bl!` with `asm_sym` [3] [1]: rust-lang/compiler-builtins#817 [2]: rust-lang/compiler-builtins#821 [3]: rust-lang/compiler-builtins#820
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 17, 2025
Update `compiler-builtins` to 0.1.155 Includes the following changes: * Replace `#[naked]` with `#[unsafe(naked)]` [1] [2] * Replace `bl!` with `asm_sym` [3] [1]: rust-lang/compiler-builtins#817 [2]: rust-lang/compiler-builtins#821 [3]: rust-lang/compiler-builtins#820 try-job: armhf-gnu try-job: aarch64-apple try-job: dist-apple-various
folkertdev
pushed a commit
to folkertdev/rust
that referenced
this pull request
Apr 17, 2025
Includes the following changes: * Replace `#[naked]` with `#[unsafe(naked)]` [1] [2] * Replace `bl!` with `asm_sym` [3] [1]: rust-lang/compiler-builtins#817 [2]: rust-lang/compiler-builtins#821 [3]: rust-lang/compiler-builtins#820
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 18, 2025
Update `compiler-builtins` to 0.1.155 Includes the following changes: * Replace `#[naked]` with `#[unsafe(naked)]` [1] [2] * Replace `bl!` with `asm_sym` [3] [1]: rust-lang/compiler-builtins#817 [2]: rust-lang/compiler-builtins#821 [3]: rust-lang/compiler-builtins#820 try-job: armhf-gnu try-job: aarch64-apple try-job: dist-apple-various
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 18, 2025
Rollup merge of rust-lang#139934 - tgross35:update-builtins, r=tgross35 Update `compiler-builtins` to 0.1.155 Includes the following changes: * Replace `#[naked]` with `#[unsafe(naked)]` [1] [2] * Replace `bl!` with `asm_sym` [3] [1]: rust-lang/compiler-builtins#817 [2]: rust-lang/compiler-builtins#821 [3]: rust-lang/compiler-builtins#820 try-job: armhf-gnu try-job: aarch64-apple try-job: dist-apple-various
github-actions Bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Apr 19, 2025
Includes the following changes: * Replace `#[naked]` with `#[unsafe(naked)]` [1] [2] * Replace `bl!` with `asm_sym` [3] [1]: rust-lang/compiler-builtins#817 [2]: rust-lang/compiler-builtins#821 [3]: rust-lang/compiler-builtins#820
github-actions Bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Apr 19, 2025
Update `compiler-builtins` to 0.1.155 Includes the following changes: * Replace `#[naked]` with `#[unsafe(naked)]` [1] [2] * Replace `bl!` with `asm_sym` [3] [1]: rust-lang/compiler-builtins#817 [2]: rust-lang/compiler-builtins#821 [3]: rust-lang/compiler-builtins#820 try-job: armhf-gnu try-job: aarch64-apple try-job: dist-apple-various
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #t-compiler/help > Does `#[cfg(bootstrap)]` get set in dependencies? this should resolve the error we see in rust-lang/rust#139934.
It's probably a good idea to validate that this will actually work, but I'm not sure how to do that.