Extern types #601
Merged
Extern types #601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackh726
approved these changes
Sep 4, 2020
Member
jackh726
left a comment
jackh726
left a comment
There was a problem hiding this comment.
Couple nits, but pretty straightforward!
| } | ||
| } | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Can you provide like a one-line comment on each of these for why this test exists (and passes as it is).
Honestly, it's probably:
extern types are always well-formed
and
extern types don't implement any builtin traits
Member
|
@bors r+ |
Contributor
|
📋 Looks like this PR is still in progress, ignoring approval. Hint: Remove [WIP] from this PR's title when it is ready for review. |
Member
|
@bors r+ |
Contributor
|
📌 Commit 404bc7e has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #595.