add Sized well-known impl and wf check #374
Conversation
nikomatsakis
left a comment
nikomatsakis
left a comment
There was a problem hiding this comment.
Seems good! I left some nits.
| } | ||
| } | ||
|
|
||
| fn add_sized_program_clauses<I: Interner>( |
There was a problem hiding this comment.
I think we should make builtin_traits/sized.rs and put this function in there
|
|
||
| let struct_datum = db.struct_datum(struct_id); | ||
|
|
||
| if struct_datum.binders.map_ref(|b| b.fields.is_empty()).value { |
There was a problem hiding this comment.
Comment:
Structs with no fields are always Sized
| return; | ||
| } | ||
|
|
||
| let last_field_ty = struct_datum |
There was a problem hiding this comment.
Let's add a comment here -- something like this:
To check if a struct type S<..> is Sized, we only have to look at its last field. This is because the WF checks for structs require that all the other fields must be Sized.
|
Addressed the nits and rebased |
|
All done and rebased |
|
@nikomatsakis wait, why did I put the constraint check into the WfSolver? It should probably be in ToProgramClauses for StructDatum, right? |
|
made a zulip thread because I have many questions about this |
2 participants
EDIT: doesnt actually close \#261, we need #368 to land first and address it