intern "substitutions" #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to support interning, we're going to want to be passing in the interner, so `collect()` is not going to work long term.
It is constructed from an iterator over results
jackh726
reviewed
Jan 5, 2020
chalk-ir/src/debug.rs
Outdated
| ) | ||
| }) | ||
| TF::debug_projection(self, fmt) | ||
| .unwrap_or_else(|| write!(fmt, "({:?}){:?}", self.associated_ty_id, &self.substitution)) |
Member
There was a problem hiding this comment.
Should this be &self.substitution.with_angle()
chalk-ir/src/family.rs
Outdated
| fn intern_goal(data: GoalData<Self>) -> Self::InternedGoal; | ||
|
|
||
| /// Lookup the `GoalData` that was interned to create a `InternedGoal`. | ||
| /// Lookup the `LifetimeData` that was interned to create a `InternedLifetime`. |
Member
There was a problem hiding this comment.
These docs don't reflect the function...
| /// index. Naturally, the kind of the variable must agree with | ||
| /// the kind of the value. | ||
| pub parameters: Vec<Parameter<TF>>, | ||
| parameters: TF::InternedSubstitution, |
Member
There was a problem hiding this comment.
At this point, why not just replace Substitution with an associated type?
Contributor
Author
There was a problem hiding this comment.
This pattern is what we use for all the "interned things". Having the newtype'd wrapper allows us to implement traits like Fold and add methods. You can't quite make Fold work without the newtype'd wrapper. The other advantage is consistency: you always write Foo<TF>, never TF::Foo, in regular code.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to directly embed
Vec<Parameter<TF>>. This branch changes those references toSubstitution<TF>which (internally) relies on anTF::InternedSubstitution. This should enable rustc to use interned slices.