Fix Build::compile_objects deadlock on parallel#829
Merged
thomcc merged 1 commit intorust-lang:mainfrom Jul 20, 2023
NobodyXu:fix-compile-objects
Merged
Fix Build::compile_objects deadlock on parallel#829thomcc merged 1 commit intorust-lang:mainfrom NobodyXu:fix-compile-objects
Build::compile_objects deadlock on parallel#829thomcc merged 1 commit intorust-lang:mainfrom
NobodyXu:fix-compile-objects
Conversation
`jobserver::Client::acquire` may block if there's not enough token. To avoid blocking, this patch waits for child in a separate thread so that once the old compiler job is done, it may continue spawning new job instead of blocking forever. Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Contributor
Author
|
P.S. This could be much easier if stdlib provides a simple async runtime. |
thomcc
approved these changes
Jul 20, 2023
Member
thomcc
left a comment
thomcc
left a comment
There was a problem hiding this comment.
Unfortunate, but seems necessary.
Contributor
Author
Thanks for the review, with this change it still spawns less threads than before, where two threads are spawned for every object. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jobserver::Client::acquiremay block if there's not enough token.To avoid blocking, this patch waits for child in a separate thread so that once the old compiler job is done, it may continue spawning new job instead of blocking forever.
This PR also makes sure that the released token is always re-acquired.