test: add regression tests for cross-arch flag_if_supported#1637
Draft
naoNao89 wants to merge 1 commit intorust-lang:mainfrom
Draft
test: add regression tests for cross-arch flag_if_supported#1637naoNao89 wants to merge 1 commit intorust-lang:mainfrom
naoNao89 wants to merge 1 commit intorust-lang:mainfrom
Conversation
…g#486) Adds tests to reproduce issue where flag_if_supported incorrectly rejects valid compiler flags during cross-compilation. Tests gracefully skip when cross-compilers are unavailable.
naoNao89
force-pushed
the
test/issue-486-flag-if-supported-cross-arch
branch
from
0ed8142 to
11628dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds tests to catch the bug from #486 where
flag_if_supportedrejects valid flags during cross-compilation.The tests check that
-Walland-std=c++11work correctly when building on ARM64 for x86_64 (and vice versa). They'll skip gracefully if cross-compilers aren't available