Fix WASM vs. WASI options #1284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@matheus23: Could you test that this actually fixes #1275? |
matheus23
added a commit
to n0-computer/quinn
that referenced
this pull request
Nov 11, 2024
|
Yeah, can confirm this fixes the compilation compared to latest released |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through all the places where we mention WASI and WASM, and tried to make sense of which places need which options. See also #1126 (comment). Still with the caveat that I have no idea if any of what I'm doing here is correct.
The effect to the options for
wasm32-unknown-unknownis that we no longer pass-fPIC, and that we now pass-fno-exceptions.Fixes #1126.
Fixes #1275.