Skip to content

Conversation

@TyPR124
Copy link

@TyPR124 TyPR124 commented Oct 14, 2020

Fix two links on cargo doc page that were broken, previously pointed to .md files on https://doc.rust-lang.org, changed these to .html

I suspect there are other dead links like this but I've only looked at the page where I found one initially.

Fix two links on cargo doc page that were broken, previously pointed to .md files on https://doc.rust-lang.org, changed these to .html
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 14, 2020
@ehuss
Copy link
Contributor

ehuss commented Oct 14, 2020

Thanks, this actually looks like it is a bug in the man page generator. I think around here it shouldn't be changing the URLs to be absolute. I'll try to fix that soonish.

@bors
Copy link
Contributor

bors commented Oct 17, 2020

☔ The latest upstream changes (presumably #8793) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@ehuss
Copy link
Contributor

ehuss commented Oct 17, 2020

Thanks for bringing this up! This should now be fixed via #8793.

@ehuss ehuss closed this Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants