Change the default edition for cargo new to 2018
#5989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it says on the tin! Some tests were updated to explicitly pass 2015 so they can continue to work on stable, and otherwise `cargo new` should now by default generate a 2018 project.
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
Member
Author
Mark-Simulacrum
approved these changes
Sep 7, 2018
| #[test] | ||
| fn simple_git() { | ||
| cargo_process("new --lib foo").env("USER", "foo").run(); | ||
| cargo_process("new --lib foo --edition 2015").env("USER", "foo").run(); |
Member
There was a problem hiding this comment.
Is it correct to assume these are temporary? I imagine in theory at least we'd want to not have this here -- most users shouldn't be passing/working in 2015 edition locally I imagine. Or, at least, we'd want tests for both.
Anyway, not a concern that needs to be resolved in this PR I think.
Member
Author
There was a problem hiding this comment.
Yes these are temporary until the 2018 edition has hit the stable channel, and then we can change these tests back.
Member
|
@bors r+ |
Contributor
|
📌 Commit cf8d6a4 has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Sep 7, 2018
Change the default edition for `cargo new` to 2018 As it says on the tin! Some tests were updated to explicitly pass 2015 so they can continue to work on stable, and otherwise `cargo new` should now by default generate a 2018 project.
Contributor
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it says on the tin! Some tests were updated to explicitly pass 2015 so they
can continue to work on stable, and otherwise
cargo newshould now by defaultgenerate a 2018 project.