Skip to content

Conversation

@JoshBrudnak
Copy link

@JoshBrudnak JoshBrudnak commented Aug 18, 2018

Added the --allow-staged command line flag to cargo fix. #5737

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

Thanks! It's a bit difficult to see what's going on here, could the rustfmt changes be left in a separate commit?

bors added a commit that referenced this pull request Aug 29, 2018
Add `--allow-staged` to `cargo fix`

Fixes #5737

This is @jljusten's branch, adapted to the testsuite changes in master.
Submitted as an alternative to #5910 to expedite #5737 resolution in time for Edition RC 1.
@bors
Copy link
Contributor

bors commented Aug 29, 2018

☔ The latest upstream changes (presumably #5943) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants