Skip to content

Conversation

@nox
Copy link
Contributor

@nox nox commented Dec 1, 2017

This fixes #4765.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matklad (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@matklad
Copy link
Contributor

matklad commented Dec 1, 2017

@bors r+

Thanks @nox!

@bors
Copy link
Contributor

bors commented Dec 1, 2017

📌 Commit 3ce50d0 has been approved by matklad

@bors
Copy link
Contributor

bors commented Dec 1, 2017

⌛ Testing commit 3ce50d0 with merge 7af29f3...

bors added a commit that referenced this pull request Dec 1, 2017
Don't recurse out of CARGO_HOME when looking for workspace root

This fixes #4765.
@bors
Copy link
Contributor

bors commented Dec 1, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: matklad
Pushing 7af29f3 to master...

@bors bors merged commit 3ce50d0 into rust-lang:master Dec 1, 2017
@nox nox deleted the cargo-home-escape branch December 1, 2017 09:08
@ehuss ehuss added this to the 1.24.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When looking for worksapce root, don't step over CARGO_HOME

5 participants