build: remove duplicate dependency, consolidate over unicode-ident #16137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unicode-ident and unicode-xid do the exact same job. Converge over unicode-ident across the workspace.
rustbot
added
A-cli
Collaborator
rustbot
removed
the
S-waiting-on-review
Contributor
|
I just wanted to note that this updates to Unicode 17, which is ahead of rustc and the language. I don't think it matters, but it might be something to be aware of. |
Member
|
Thanks for that! Yeah, the reissued version for Unicode 17.0 is mostly around recommend scripts, which we don't use. https://www.unicode.org/reports/tr31/tr31-43.html#Modifications
|
Contributor
Author
|
Hello @ehuss, |
Contributor
|
I meant that unicode-xid 0.2.6 is Unicode 16, and that is what is used in the compiler for the lexer. |
Contributor
Author
|
I see, you are right. Thanks for clarifying! |
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Oct 29, 2025
Update cargo submodule 11 commits in 344c4567c634a25837e3c3476aac08af84cf9203..6c1b6100343691341b9e76c5acc594e78220f963 2025-10-15 15:01:32 +0000 to 2025-10-28 16:27:52 +0000 - feat(build-analysis): JSONL-based logging infra (rust-lang/cargo#16150) - feat: support array of any types in Cargo config (rust-lang/cargo#16103) - test(git): add more fetch-index backend interop (rust-lang/cargo#16162) - feat(git): support shallow fetch for Git CLI backend (rust-lang/cargo#16156) - Fix mdman to not incorrectly strip `<p>` tags (rust-lang/cargo#16158) - chore(triagebot): enable range-diff and review-changes-since (rust-lang/cargo#16152) - Avoid specifying which version will change behavior (rust-lang/cargo#16153) - Make shell completion variables private. (rust-lang/cargo#16144) - More warning conversions (rust-lang/cargo#16143) - Bump openssl-src to 300.3.5.4+3.5.4 (rust-lang/cargo#16140) - build: remove duplicate dependency, consolidate over unicode-ident (rust-lang/cargo#16137)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
The crates
unicode-identandunicode-xiddo the exact same job.This PR replaces the few
unicode-xidusages and converges overunicode-identacross the workspace.Thanks!